Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: tidy net benchmarks #10446

Merged
merged 2 commits into from
Jan 5, 2017
Merged

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented Dec 25, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)
  • benchmark
Description of change

These commits just tidy things up a bit for the net benchmarks.

@mscdex mscdex added benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem. labels Dec 25, 2016
@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. lts-watch-v6.x labels Dec 25, 2016
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
@mscdex
Copy link
Contributor Author

mscdex commented Jan 5, 2017

@mscdex mscdex merged commit f955c73 into nodejs:master Jan 5, 2017
@mscdex mscdex deleted the benchmark-net-tidy branch January 5, 2017 07:49
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 24, 2017
PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
PR-URL: nodejs#10446
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Jan 29, 2017
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 7, 2017
PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
punycode/ICU is not specific to any particular module, so move it to
a more generic location.

PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #10446
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmark Issues and PRs related to the benchmark subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants